Skip to content

provide signal names to SimResult plot #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

provide signal names to SimResult plot #991

merged 1 commit into from
May 16, 2025

Conversation

@baggepinnen
Copy link
Member

@baggepinnen baggepinnen commented May 8, 2025 

using Plots
A = [-10 2; 3 -40]
B = [5 6; 7 8]
C = [9 10; 11 12]
G = ss(A, B, C, 0)
step_response = step(G, 10.0)
plot(step_response, title="", xlabel="Time (s)", lw=2, legend=:topright, input_names=["a", "b"], output_names=["c", "d"])

image

@JuliaControlBot
Copy link

JuliaControlBot commented May 8, 2025

This is an automated message.
Plots were compared to references. 1/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.008 Reference New

@codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.44%. Comparing base (8b43e08) to head (de72455).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
lib/ControlSystemsBase/src/plotting.jl 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #991   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files          41       41           
  Lines        5006     5006           
=======================================
  Hits         4628     4628           
  Misses        378      378

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@baggepinnen baggepinnen marked this pull request as ready for review May 16, 2025 07:01
@baggepinnen baggepinnen merged commit 2729dd5 into master May 16, 2025
6 of 8 checks passed
@baggepinnen baggepinnen deleted the plotlabels branch May 16, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baggepinnen @JuliaControlBot